[HOTFIX]fix some compilation failures in core worker test#22855
Merged
kfstorm merged 1 commit intoray-project:masterfrom Mar 8, 2022
Merged
[HOTFIX]fix some compilation failures in core worker test#22855kfstorm merged 1 commit intoray-project:masterfrom
kfstorm merged 1 commit intoray-project:masterfrom
Conversation
SongGuyang
approved these changes
Mar 7, 2022
Contributor
|
@kfstorm Do we still need this test? |
Member
|
@SongGuyang I'm trying to remove it in #21308 |
Contributor
Author
|
Shall we merge this, no matter we would remove or reenable it? @kfstorm @SongGuyang |
Contributor
|
I think we can merge this first. |
kfstorm
approved these changes
Mar 8, 2022
Member
|
Let me merge it. |
architkulkarni
pushed a commit
to architkulkarni/ray
that referenced
this pull request
Apr 11, 2022
…t#22855) There're some compilation failures in core worker test when we build project using `bazel build //:all`. It seems broken and not integrated in CI.
architkulkarni
added a commit
that referenced
this pull request
Apr 11, 2022
* [HOTFIX]fix some compilation failures in core worker test (#22855) There're some compilation failures in core worker test when we build project using `bazel build //:all`. It seems broken and not integrated in CI. * Lint Co-authored-by: Tao Wang <dooku.wt@antfin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
There're some compilation failures in core worker test when we build project using
bazel build //:all. It seems broken and not integrated in CI.Related issue number
Checks
scripts/format.shto lint the changes in this PR.